Re: [RFA 04/11] Use gdbpy_enter in python.c

[Pedro Alves <palves at redhat dot com>]

LGTM.  Formatting nits below.

On 11/12/2016 09:28 PM, Tom Tromey wrote:
> @@ -1885,24 +1870,31 @@ gdbpy_finish_initialization (const struct extension_language_defn *extlang)
>  		 "Could not load the Python gdb module from `%s'.\n"
>  		 "Limited Python support is available from the _gdb module.\n"
>  		 "Suggest passing --data-directory=/path/to/gdb/data-directory.\n"),
> -		 gdb_pythondir);
> -      do_cleanups (cleanup);
> -      return;
> +	       gdb_pythondir.c_str ());

tabs/spaces here?

> +      /* We return "success" here as we've already emitted the
> +	 warning.  */
> +      return true;
>      }


> +  if (! do_finish_initialization (extlang))

No space after '!'.

Thanks,
Pedro Alves