This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.

From: Gary Benson <gbenson at redhat dot com>
To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
Cc: palves at redhat dot com, eliz at gnu dot org, brobecker at adacore dot com, gdb-patches at sourceware dot org
Date: Thu, 10 Nov 2016 12:37:01 +0000
Subject: Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.
Authentication-results: sourceware.org; auth=none
References: <1478166445-21370-1-git-send-email-walfred.tedeschi@intel.com> <1478166445-21370-2-git-send-email-walfred.tedeschi@intel.com>

Walfred Tedeschi wrote:
> diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
> index bbce742..376ca9d 100755
> --- a/gdb/gdbserver/configure
> +++ b/gdb/gdbserver/configure
> @@ -7591,6 +7591,32 @@ _ACEOF
>  fi
>  
>  
> +# See if <sys/user.h> supports the %fs_base and %gs_bas amd64 segment registers.
> +# Older amd64 Linux's don't have the fs_base and gs_base members of
> +# `struct user_regs_struct'.

I'd mildly prefer to see these comments wrapped at 72 columns, but
I know the rules are different in autoconf files so please don't
consider this a blocker.

Thanks,
Gary

-- 
http://gbenson.net/

Follow-Ups:
- Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.
  - From: Pedro Alves

References:
- [PATCH 0/2] amd64: add fs_base and gs_base
  - From: Walfred Tedeschi
- [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.
  - From: Walfred Tedeschi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]