This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, RFC] Add support for choosing disassembler cpu in GDB for POWER.


On 10/27/16 4:40 AM, Pedro Alves wrote:
I couldn't quite get why you need so much power specific parsing
code in ppc-tdep.c, though.  What would be necessary to be able to
move most of that set/show handling to the common code?

Working on that now.


I also wonder if you really want to stick with
"set powerpc disassembler <cpu>" instead of
"set powerpc disassembler-options <options>".

I.e., I wonder about making the power one defined exactly like:

 "like 'set disassembler-options', but sets power disassembler
  options even if the current arch is not power."

Once we move all of this code to generic code, do we really
even need the arch specific command?



The idea was to define the new command as exposing objdump's -M option:

  -M, --disassembler-options=OPT Pass text OPT on to the disassembler

It happens that on power that allows only changing the cpu.  Whereas
for ARM that tweaks other things.  x86 has options for both cpu and
syntax.  See what an --enable-targets=all build of
objdump says in its --help:

Ok, got it.

Peter




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]