This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, v4] PR 20569, segv in follow_exec
On 10/25/2016 08:41 PM, Luis Machado wrote:
> Going back to the flags problem, maybe adding "add_flags" as argument to
> symbol_file_add_main_1, just like symbol_file_add, and appending those
> flags to the existing flag variable there would make things work?
I've now cleaned up that patch, and simply rebasing yours on top
shows what I meant:
src/gdb/exec.c:184:59: error: could not convert ‘flags’ from
‘symfile_add_flags {aka enum_flags<symfile_add_flag>}’ to
‘objfile_flags {aka enum_flags<objfile_flag>}’
symbol_file_add_main_1 (exec_file_host, from_tty, flags);
^
Makefile:1138: recipe for target 'exec.o' failed
I.e., the existing flags parameter to symbol_file_add_main_1
is _not_ a symfile_add_flags. We can't just use it as is.
So yes, I think so. I was just doing that here, this minute.
But I was replacing the from_tty parameter symbol_file_add_main
with a symfile_add_flags instead. Let me do that and send
both patches.
- References:
- [PATCH, v4] PR 20569, segv in follow_exec
- Re: [PATCH, v4] PR 20569, segv in follow_exec
- Re: [PATCH, v4] PR 20569, segv in follow_exec
- Re: [PATCH, v4] PR 20569, segv in follow_exec
- Re: [PATCH, v4] PR 20569, segv in follow_exec
- Re: [PATCH, v4] PR 20569, segv in follow_exec