This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix phony iconv build
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Mon, 17 Oct 2016 09:59:56 -0600
- Subject: Re: [PATCH] Fix phony iconv build
- Authentication-results: sourceware.org; auth=none
- References: <1476713788-18547-1-git-send-email-palves@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar
Pedro> iterator into a class). The problem is that iconv_t is now exposed in
Pedro> charset.h, while before it was only used in charset.c. gdb/charset.c,
Pedro> under #ifdef PHONY_ICONV, does:
I'm sorry about that.
Pedro> So it seems the simplest is to use 'int' in the header file too.
Pedro> Tromey, WDYT?
Looks good, thanks.
Tom