Re: [PATCH] Consolidate target_mourn_inferior between GDB and gdbserver

[Jon Turney <jon dot turney at dronecode dot org dot uk>]

On 19/09/2016 05:19, Sergio Durigan Junior wrote:
> On Thursday, September 15 2016, Pedro Alves wrote:
> > On 09/12/2016 05:51 AM, Sergio Durigan Junior wrote:
> > Thanks, patch is OK.
> >
> > > I'd appreciate a special look at gdb/windows-nat.c's modification
> > > because I wasn't really sure what to do there.  It seemed to me that
> > > maybe I should build a ptid out of the process information there, but
> > > then I am almost sure the assertion on GDB's side would trigger.
> >
> > Just leave it passing inferior_ptid like all other places, which is
> > a no-op.  We're certain the assertion does not fail this way.
>
> Thanks, pushed.
>
>   bc1e6c81d5b77d78282c47f6fd7f697e564a6eb6

This seems to miss one use of target_mourn_inferior() in windows-nat.c.

> ../../gdb/windows-nat.c: In function ‘void windows_kill_inferior(target_ops*)’:
> ../../gdb/windows-nat.c:2467:26: error: too few arguments to function ‘void target_mourn_inferior(ptid_t)’
>    target_mourn_inferior (); /* Or just windows_mourn_inferior?  */
>                           ^

Patch attached.

Attachment: 0001-Fix-a-use-of-target_mourn_inferior-in-windows-nat.c.patch
Description: Text document