This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Avoid -Wduplicated-cond warnings in gdb/python


On 09/07/2016 05:26 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> Tom> I tried building gdb with -Wduplicated-cond.  This patch fixes the
> Tom> simpler issue that was found.
> 
> [...]
> 
> Tom> 2016-07-21  Tom Tromey  <tom@tromey.com>
> 
> Tom> 	* python/py-value.c (convert_value_from_python): Make PyInt_Check
> Tom> 	conditional on Python 2.
> Tom> 	* python/py-arch.c (archpy_disassemble): Make PyInt_Check
> Tom> 	conditional on Python 2.
> 
> Ping.
> I realized today that this was never reviewed.

This is OK.  I'd be totally fine with you self approving
this...

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]