This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] PR python/18565 - make Frame.function work for inline frames


On 08/03/2016 04:13 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
> 
>>> In any case, IMO this would be the subject of a separate patch.
> 
> Yao> This is the prerequisite of Tom's patch, no?  It guarantees that *FUNNAME
> Yao> is not allocated if exception is thrown, otherwise *FUNAME is allocated.
> Yao> Tom's patch relies on this behaviour.
> 
> Yao> I am OK with Tom's original patch, but we need to fix find_frame_funname
> Yao> first.
> 
> Here's a patch.  Please review.
> 

LGTM.

> I'd like to check this and the other into the 7.12 branch as well.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]