This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/6] Change reopen_exec_file to check result of stat
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 28 Jun 2016 15:21:26 +0100
- Subject: Re: [RFA 1/6] Change reopen_exec_file to check result of stat
- Authentication-results: sourceware.org; auth=none
- References: <1465248812-23902-1-git-send-email-tom at tromey dot com> <1465248812-23902-2-git-send-email-tom at tromey dot com>
On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey <tom@tromey.com> wrote:
> This seems to be a real bug found by -Wunused-but-set-variable. If
> "stat" fails for some reason, gdb would use the uninitialized "st".
>
> 2016-06-06 Tom Tromey <tom@tromey.com>
>
> * corefile.c (reopen_exec_file): Only examine st.st_mtime if stat
> succeeded.
Patch is good to me.
--
Yao (éå)