This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Fortran: Handle cyclic pointers.


Bernhard Heckel <bernhard.heckel@intel.com> writes:

Patch is a good to me, a nit below,

>    /* Don't resolve not associated pointers.  */
> -  if (type_not_associated (type))
> +  if (type_not_associated (type) || 1 != top_level)
>      return type;

top_level is used as a boolean, so " || !top_level" is better IMO.
We also need to add comments on why do we do so.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]