This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Fortran: Handle cyclic pointers.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Bernhard Heckel <bernhard dot heckel at intel dot com>
- Cc: qiyaoltc at gmail dot com, eliz at gnu dot org, gdb-patches at sourceware dot org
- Date: Fri, 17 Jun 2016 16:16:04 +0100
- Subject: Re: [PATCH 3/3] Fortran: Handle cyclic pointers.
- Authentication-results: sourceware.org; auth=none
- References: <1465220233-32286-1-git-send-email-bernhard dot heckel at intel dot com> <1465220233-32286-4-git-send-email-bernhard dot heckel at intel dot com>
Bernhard Heckel <bernhard.heckel@intel.com> writes:
Patch is a good to me, a nit below,
> /* Don't resolve not associated pointers. */
> - if (type_not_associated (type))
> + if (type_not_associated (type) || 1 != top_level)
> return type;
top_level is used as a boolean, so " || !top_level" is better IMO.
We also need to add comments on why do we do so.
--
Yao (éå)