This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 8 Jun 2016 15:59:44 +0100
- Subject: Re: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features
- Authentication-results: sourceware.org; auth=none
- References: <1465377976-21678-1-git-send-email-andrew dot burgess at embecosm dot com> <CAH=s-PMpVE4aEYETjwPJwKN_TTLSF8dRBW3pcmhmyMh=cNEgaQ at mail dot gmail dot com> <20160608114017 dot GB26734 at embecosm dot com>
On Wed, Jun 8, 2016 at 12:40 PM, Andrew Burgess
> diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
> index fbe896c..1ec33d8 100644
> --- a/gdb/testsuite/gdb.base/callfuncs.exp
> +++ b/gdb/testsuite/gdb.base/callfuncs.exp
> @@ -26,8 +26,7 @@ if [support_complex_tests] {
> # Some targets can't do function calls, so don't even bother with this
> # test.
> if [target_info exists gdb,cannot_call_functions] {
> - setup_xfail "*-*-*" 2416
> - fail "This target can not call functions"
> + unsupported "This target can not call functions"
> continue
> }
>
That change makes sense to me. UNSUPPORTED is better XFAIL.
There are many instances,
./gdb.base/unwindonsignal.exp: setup_xfail "*-*-*" 2416
./gdb.base/call-signal-resume.exp: setup_xfail "*-*-*" 2416
./gdb.base/call-rt-st.exp: setup_xfail "*-*-*" 2416
./gdb.base/call-ar-st.exp: setup_xfail "*-*-*" 2416
./gdb.base/ptype.exp: setup_xfail "*-*-*" 2416
./gdb.base/callexit.exp: setup_xfail "*-*-*" 2416
./gdb.base/callfuncs.exp: setup_xfail "*-*-*" 2416
./gdb.base/nodebug.exp: setup_xfail "*-*-*" 2416
./gdb.base/call-strs.exp: setup_xfail "*-*-*" 2416
./gdb.base/printcmds.exp: setup_xfail "*-*-*" 2416
./gdb.base/printcmds.exp: setup_xfail "*-*-*" 2416
./gdb.threads/thread-unwindonsignal.exp: setup_xfail "*-*-*" 2416
./gdb.threads/hand-call-in-threads.exp: setup_xfail "*-*-*" 2416
./gdb.threads/interrupted-hand-call.exp: setup_xfail "*-*-*" 2416
./gdb.cp/templates.exp: setup_xfail "*-*-*" 2416
./gdb.cp/gdb2495.exp: setup_xfail "*-*-*" 2416
./gdb.cp/virtfunc.exp: setup_xfail "*-*-*" 2416
so I think we need to clean them up too. I don't think 2416 is the PR number
in sourceware.org bugzilla, so we don't loose any information after
the cleanup. The patch can go in without another review.
--
Yao (éå)