This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4][PR gdb/19893] Fix handling of synthetic C++ references
- From: Pedro Alves <palves at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 31 May 2016 20:08:48 +0100
- Subject: Re: [PATCH v4][PR gdb/19893] Fix handling of synthetic C++ references
- Authentication-results: sourceware.org; auth=none
- References: <20160531183523 dot 882-1-martin dot galvan at tallertechnologies dot com> <218e5048-2ea1-2dfe-71ec-ee973ed6531f at redhat dot com> <CAOKbPbbixq_BkLH3pEU5uDySBNM8NhDzkOu_ksiHgBdU5UAYzg at mail dot gmail dot com>
On 05/31/2016 08:01 PM, Martin Galvan wrote:
> I also noticed Bugzilla detected that I commited something related to
> the bug and automatically sent an e-mail reporting it. That's pretty
> cool, how does it work so I can always make it happen? Does it scan
> the commit message for the PR number?
Correct.
It's also standard procedure to put the PR number in the ChangeLog [1],
which I totally forgot to point out in review. Could you add
it (both gdb/ and gdb/testsuite/ ChangeLogs) now, please? No need to
post that patch, just go ahead and push it.
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
Thanks,
Pedro Alves