This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Add emit_less_unsigned test in trace-condition.exp
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 27 May 2016 08:36:10 -0400
- Subject: Re: [PATCH 2/4] Add emit_less_unsigned test in trace-condition.exp
- Authentication-results: sourceware.org; auth=none
- References: <1463504594-4419-1-git-send-email-antoine dot tremblay at ericsson dot com> <1463504594-4419-2-git-send-email-antoine dot tremblay at ericsson dot com> <4099b62e-3ac6-e184-104b-5cf5bd1b3b4d at redhat dot com>
Pedro Alves writes:
> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>
>
>> diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp
>> index fa031ba..f5b59b1 100644
>> --- a/gdb/testsuite/gdb.trace/trace-condition.exp
>> +++ b/gdb/testsuite/gdb.trace/trace-condition.exp
>> @@ -151,6 +151,7 @@ foreach trace_command { "trace" "ftrace" } {
>> test_tracepoints $trace_command "(0xaaaaaaaa ^ 0x55555555) == 0xffffffff" 10
>> test_tracepoints $trace_command "~0xaaaaaaaa == 0x55555555" 10
>> test_tracepoints $trace_command "21 < 42" 10
>> + test_tracepoints $trace_command "21U < 42U" 10
>
> Shouldn't we add:
>
> test_tracepoints $trace_command "42U < 21U" 0
>
> ?
Yes as previous comments, will do.