This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Add emit_less_unsigned test in trace-condition.exp


Pedro Alves writes:

> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>
>
>> diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp
>> index fa031ba..f5b59b1 100644
>> --- a/gdb/testsuite/gdb.trace/trace-condition.exp
>> +++ b/gdb/testsuite/gdb.trace/trace-condition.exp
>> @@ -151,6 +151,7 @@ foreach trace_command { "trace" "ftrace" } {
>>      test_tracepoints $trace_command "(0xaaaaaaaa ^ 0x55555555) == 0xffffffff" 10
>>      test_tracepoints $trace_command "~0xaaaaaaaa == 0x55555555" 10
>>      test_tracepoints $trace_command "21 < 42" 10
>> +    test_tracepoints $trace_command "21U < 42U" 10
>
> Shouldn't we add:
>
>     test_tracepoints $trace_command "42U < 21U" 0
>
> ?


Yes as previous comments, will do.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]