This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Rename target descriptors to reflect actual content of descriptor.
- From: Pedro Alves <palves at redhat dot com>
- To: Michael Sturm <michael dot sturm at intel dot com>, mark dot kettenis at xs4all dot nl, eliz at gnu dot org
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 May 2016 11:44:50 +0100
- Subject: Re: [PATCH 2/4] Rename target descriptors to reflect actual content of descriptor.
- Authentication-results: sourceware.org; auth=none
- References: <1463143833-24399-1-git-send-email-michael dot sturm at intel dot com> <1463143833-24399-3-git-send-email-michael dot sturm at intel dot com>
It's "target descriptions", not "target descriptors":
https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Descriptions.html#Target-Descriptions
That typo appears in a lot of places.
On 05/13/2016 01:50 PM, Michael Sturm wrote:
> To better reflect the actual feature set covered by the IA target
> descriptors, the existing descriptors are renamed. Each feature of
> the extended state is added to the name of a descriptor or xstate mask
> starting from AVX.
> For example, amd64-mpx-avx512-linux becomes amd64-avx-mpx-avx512-linux,
> while amd64-avx-linux remains unchanged.
> Likewise, the corrsponding xstate masks are changed, e.g. from
"corresponding"
> X86_XSTATE_MPX_AVX512_MASK to X86_XSTATE_AVX_MPX_AVX512_MASK.
>
> gdb/Changelog:
> 2016-04-18 Michael Sturm <michael.sturm@intel.com>
>
> * amd64-linux-tdep.c (features/i386/amd64-avx512-linux.c): Renamed
> include.
> (features/i386/x32-avx512-linux.c): Likewise.
> (amd64_linux_core_read_description): Renamed X86_XSTATE_MPX_AVX512_MASK,
> X86_XSTATE_AVX512_MASK, desc_x32_avx512_linux, tdesc_amd64_avx512_linux.
> (_initialize_amd64_linux_tdep): Renamed
> initialize_tdesc_amd64_avx512_linux, initialize_tdesc_x32_avx512_linux.
> * amd64-linux-tdep.h (tdesc_amd64_avx512_linux): Renamed prototype.
> (tdesc_x32_avx512_linux): Likewise.
> * amd64-tdep.c (features/i386/amd64-avx512.c): Renamed include.
> (features/i386/x32-avx512.c): Likewise.
> (amd64_target_description): Renamed X86_XSTATE_MPX_AVX512_MASK,
> X86_XSTATE_AVX512_MASK, tdesc_amd64_avx512.
> (_initialize_amd64_tdep): Renamed initialize_tdesc_amd64_avx512. Renamed
> initialize_tdesc_x32_avx512.
> * common/x86-xstate.h (X86_XSTATE_AVX512_MASK): Renamed.
> (86_XSTATE_MPX_AVX512_MASK): Likewise.
> (X86_XSTATE_ALL_MASK): Renamed X86_XSTATE_MPX_AVX512_MASK.
> * features/Makefile (WHICH): Renamed i386/i386-avx512,
> i386/i386-avx512-linux, i386/amd64-avx512, i386/amd64-avx512-linux,
> i386/x32-avx512, i386/x32-avx512-linux.
> (i386/i386-avx512-expedite, i386/i386-avx512-linux-expedite,
> i386/amd64-avx512-expedite, i386/amd64-avx512-linux-expedite,
> i386/x32-avx512-expedite, i386/x32-avx512-linux-expedite): Renamed
> expedites.
> (XMLTOC): Renamed i386/amd64-avx512-linux.xml, i386/amd64-avx512.xml,
> i386/i386-avx512-linux.xml, i386/i386-avx512.xml,
> i386/x32-avx512-linux.xml, i386/x32-avx512.xml.
> ($(outdir)/i386/i386-avx512.dat): Renamed dat file in rule.
> ($(outdir)/i386/i386-avx512-linux.dat): Likewise.
> ($(outdir)/i386/amd64-avx512.dat): Likewise.
> ($(outdir)/i386/amd64-avx512-linux.dat): Likewise.
> ($(outdir)/i386/x32-avx512.dat): Likewise.
> ($(outdir)/i386/x32-avx512-linux.dat): Likewise.
> * features/i386/amd64-avx512-linux.c: Regenerated from renamed XML file.
> * features/i386/amd64-avx512-linux.xml: Renamed XML file.
> * features/i386/amd64-avx512.c: Regenerated from renamed XML file.
> * features/i386/amd64-avx512.xml: Renamed XML file.
> * features/i386/i386-avx512-linux.c: Regenerated from renamed XML file.
> * features/i386/i386-avx512-linux.xml: Renamed XML file.
> * features/i386/i386-avx512.c: Regenerated from renamed XML file.
> * features/i386/i386-avx512.xml: Renamed XML file.
> * features/i386/x32-avx512-linux.c: Regenerated from renamed XML file.
> * features/i386/x32-avx512-linux.xml: Renamed XML file.
> * features/i386/x32-avx512.c: Regenerated from renamed XML file.
> * features/i386/x32-avx512.xml: Renamed XML file.
> * i386-linux-tdep.c (features/i386/i386-avx512-linux.c): Renamed include.
> (i386_linux_core_read_description): Renamed X86_XSTATE_MPX_AVX512_MASK,
> X86_XSTATE_AVX512_MASK, tdesc_i386_avx512_linux.
> (_initialize_i386_linux_tdep): Renamed initialize_tdesc_i386_avx512_linux.
> * i386-linux-tdep.h (tdesc_i386_avx512_linux): Renamed prototype.
> * i386-tdep.c (features/i386/i386-avx512.c): Renamed include.
> (i386_register_reggroup_p): Renamed X86_XSTATE_AVX512_MASK.
> (i386_validate_tdesc_p): Likewise.
> (i386_target_description): Renamed X86_XSTATE_MPX_AVX512_MASK,
> tdesc_i386_avx512.
> (_initialize_i386_tdep): Renamed initialize_tdesc_i386_avx512.
> * regformats/i386/amd64-avx512-linux.dat: Regenerated from renamed XML
> file.
> * regformats/i386/amd64-avx512.dat: Likewise.
> * regformats/i386/i386-avx512-linux.dat: Likewise.
> * regformats/i386/i386-avx512.dat: Likewise.
> * regformats/i386/x32-avx512-linux.dat: Likewise.
> * regformats/i386/x32-avx512.dat: Likewise.
> * x86-Linux-nat.c (x86_linux_read_description): Renamed
> X86_XSTATE_MPX_AVX512_MASK, X86_XSTATE_AVX512_MASK,
> tdesc_x32_avx512_linux, tdesc_amd64_avx512_linux, tdesc_i386_avx512_linux.
>
> gdbserver/Changelog:
> 2016-04-18 Michael Sturm <michael.sturm@intel.com>
>
> * Makefile.in (clean): Renamed i386-avx512.c, i386-avx512-linux.c,
> amd64-avx512.c, amd64-avx512-linux.c, x32-avx512.c, x32-avx512-linux.c.
> (i386-avx512-linux-ipa.o): Renamed rule and source files.
> (amd64-avx512-linux-ipa.o): Likewise.
> (i386-avx512.c): Renamed rule, source fils and dat files.
> (i386-avx512-linux.c): Likewise.
> (amd64-avx512.c): Likewise.
> (amd64-avx512-linux.c): Likewise.
> (x32-avx512.c): Likewise.
> (x32-avx512-linux.c): Likewise.
> * configfure.srv (srv_i386_regobj): Renamed i386-avx512.o.
> (i386_linux_regobj): Renamed i386-avx512-linux.o.
> (srv_amd64_regobj): Renamed amd64-avx512.o, x32-avx512.o.
> (srv_amd64_linux_regobj): Renamed amd64-avx512-linux.o,
> x32-avx512-linux.o.
> (ipa_i386_linux_regobj): Renamed i386-avx512-linux-ipa.o.
> (ipa_amd64_linux_regobj): Renamed amd64-avx512-linux-ipa.o.
> (srv_i386_xmlfiles): Renamed i386/i386-avx512.xml.
> (srv_amd64_xmlfiles): Renamed i386/amd64-avx512.xml, i386/x32-avx512.xml.
> (srv_i386_linux_xmlfiles): Renamed i386/i386-avx512-linux.xml.
> (srv_amd64_linux_xmlfiles): Renamed i386/amd64-avx512-linux.xml,
> i386/x32-avx512-linux.xml).
> * linux-amd64-ipa.c (get_ipa_tdesc): Renamed X86_TDESC_AVX512 and returned
> tdesc for that case.
> (initialize_low_tracepoint): Renamed init_registers_amd64_avx512_linux.
> * linux-i386-ipa.c (get_ipa_tdesc): Rename X86_TDESC_AVX512 and tdesc
> returned for that case.
> (initialize_low_tracepoint): Renamed init_registers_i386_avx512_linux.
> * linux-x86-low.c (x86_linux_read_description): Renamed
> X86_XSTATE_AVX512_MASK and tdesc returned for that case.
> (x86_get_ipa_tdesc_idx): Renamed tdesc_amd64_avx512_linux,
> tdesc_x32_avx512_linux and mask returned for these descriptors.
> Renamed tdesc_i386_avx512_linux and mask returned for that descriptor.
> (initialize_low_arch): Renamed init_registers_amd64_avx512_linux,
> init_registers_x32_avx512_linux, init_registers_i386_avx512_linux.
> * linux-x86-tdesc.h (enum x86_linux_tdesc): Renamed X86_TDESC_AVX512.
> (init_registers_amd64_avx512_linux): Renamed prototype.
> (tdesc_amd64_avx512_linux): Likewise.
> (init_registers_x32_avx512_linux): Likewise.
> (tdesc_x32_avx512_linux): Likewise.
> (init_registers_i386_avx512_linux): Likewise.
> (tdesc_i386_avx512_linux): Likewise.
Say "Rename", "Regenerate", etc., as if you were giving order
to the code.
What I skimmed looked OK, but please re-post a "git diff -M"
version, so that we can see through the file renames.
Thanks,
Pedro Alves