This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix syntax error in annota-input-while-running.exp
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Francis Ricci <francisjricci at gmail dot com>
- Cc: gdb-patches at sourceware dot org, sas at fb dot com, fjricci at fb dot com
- Date: Tue, 24 May 2016 12:13:00 +0100
- Subject: Re: [PATCH] Fix syntax error in annota-input-while-running.exp
- Authentication-results: sourceware.org; auth=none
- References: <CA+i-QGjS4QBLkBbsbd0i1JxudyW4jPHrGmAyQTjtQnjrJ1K8Mg at mail dot gmail dot com>
Francis Ricci <francisjricci@gmail.com> writes:
Hi Francis,
Thanks for your patch,
> annota-input-while-running.exp to crash the test suite runner.
>
> This is my first gdb contribution, so I have not signed a copyright
> assignment form. However, from reading gdb/CONTRIBUTE, it looks like
> this is not necessary for small changes.
You can get more from
https://sourceware.org/gdb/wiki/ContributionChecklist
>
> 2016-05-22 Francis Ricci <francisjricci@gmail.com>
There are two spaces before and after your name.
>
> * gdb.base/annota-input-while-running.exp: Fix syntax error.
Patch below is pushed in.
--
Yao (éå)
From 6163bbf3310989e383079e85f9a2c2ee6ca8d58d Mon Sep 17 00:00:00 2001
From: Francis Ricci <francisjricci@gmail.com>
Date: Tue, 24 May 2016 12:07:00 +0100
Subject: [PATCH] Fix syntax error in annota-input-while-running.exp
This patch fixes a syntax error which caused a failure in
annota-input-while-running.exp to crash the test suite runner.
2016-05-24 Francis Ricci <francisjricci@gmail.com>
* gdb.base/annota-input-while-running.exp: Fix syntax error.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1f0e3f9..c50edad 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2016-05-24 Francis Ricci <francisjricci@gmail.com> (tiny patch)
+
+ * gdb.base/annota-input-while-running.exp: Fix syntax error.
+
2016-05-23 Tom Tromey <tom@tromey.com>
PR python/19438, PR python/18393:
diff --git a/gdb/testsuite/gdb.base/annota-input-while-running.exp b/gdb/testsuite/gdb.base/annota-input-while-running.exp
index adc96e4..fc2e608 100644
--- a/gdb/testsuite/gdb.base/annota-input-while-running.exp
+++ b/gdb/testsuite/gdb.base/annota-input-while-running.exp
@@ -25,8 +25,8 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug] == -1} {
# Because runto_main doesn't know how to handle the prompt with annotations,
# run to main before we set the annotation level.
if ![runto_main] then {
-- fail "Can't run to main"
-- return 1
+ fail "Can't run to main"
+ return 1
}
# NOTE: this prompt is OK only when the annotation level is > 1