This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve trace and ftrace condition testing


Yao Qi writes:

> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> Hi Antoine,
>
>> This patch improves the trace and ftrace condition testing so that:
>>
>> - Almost all ftrace emit operations are tested (missing emit_gt_goto,
>> emit_lt_goto, emit_pop, I could not figure out the condition for those).
>> - Conditions are tested with 32 and 64 bits integers, signed and unsigned
>> where relevant.
>> - Conditions are tested with 8 to 64 bits variables where relevant (emit_ref).
>>
>> It also merges all trace conditions testing from ftrace.exp in
>> trace-condition.exp.
>
> I go through your patch, and I think it's better to split your patch,
> because your single patch include too much changes, which are
> independent to each other.

OK will do, thanks.

Antoine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]