This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Improve trace and ftrace condition testing
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Mon, 9 May 2016 07:07:28 -0400
- Subject: Re: [PATCH] Improve trace and ftrace condition testing
- Authentication-results: sourceware.org; auth=none
- References: <1461941980-16462-1-git-send-email-antoine dot tremblay at ericsson dot com> <86mvo5db0h dot fsf at gmail dot com>
Yao Qi writes:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> Hi Antoine,
>
>> This patch improves the trace and ftrace condition testing so that:
>>
>> - Almost all ftrace emit operations are tested (missing emit_gt_goto,
>> emit_lt_goto, emit_pop, I could not figure out the condition for those).
>> - Conditions are tested with 32 and 64 bits integers, signed and unsigned
>> where relevant.
>> - Conditions are tested with 8 to 64 bits variables where relevant (emit_ref).
>>
>> It also merges all trace conditions testing from ftrace.exp in
>> trace-condition.exp.
>
> I go through your patch, and I think it's better to split your patch,
> because your single patch include too much changes, which are
> independent to each other.
OK will do, thanks.
Antoine