This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Involve gdbarch in taking DWARF register pieces
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, gdb-patches at sourceware dot org, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>
- Date: Mon, 18 Apr 2016 14:53:46 +0100
- Subject: Re: [PATCH 2/2] Involve gdbarch in taking DWARF register pieces
- Authentication-results: sourceware.org; auth=none
- References: <20160415180943 dot 4FEE857EE at oc7340732750 dot ibm dot com> <571134CD dot 8080507 at redhat dot com> <m3shyjw2t3 dot fsf at oc1027705133 dot ibm dot com>
On 04/18/2016 12:53 PM, Andreas Arnez wrote:
> On Fri, Apr 15 2016, Pedro Alves wrote:
>
>> Could we have some comment somewhere on what a "part" is?
>>
>> This comment isn't very enlightening, IMHO:
>>
>> +# Locate a part of size LEN within register *REGNUM, possibly overwriting
>> +# *REGNUM. Return the offset of the part within the (possibly adjusted)
>> +# register.
>> +m:int:register_part:int len, int *regnum:len, regnum::default_register_part::0
>>
>> Reading this in isolation I have no idea what it's for. I skimmed the patch
>> and didn't find any. Sorry if it's there and I missed it.
>
> Hm, I used the word "part" to imply a slightly more general meaning than
> the DWARF term "piece". But that may actually be counterproductive...
> So how about renaming the method to "register_piece" and then adjusting
> the comment like this:
>
> Determine the placement of a DWARF piece (DW_OP_piece) of size LEN
> within register *REGNUM, possibly overwriting *REGNUM. Return the
> offset of the piece within the (possibly adjusted) register. This
> method also applies when interpreting a register as a LEN-sized type.
>
> Does this help?
Yes, it does. Thanks.
I'd suggest even calling it "dwarf_register_piece_placement" for
caller clarity?
--
Pedro Alves