This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] Fix solib-display.exp remote check
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 11 Apr 2016 22:32:30 +0100
- Subject: Re: [PATCH 4/4] Fix solib-display.exp remote check
- Authentication-results: sourceware.org; auth=none
- References: <1459912543-15328-1-git-send-email-simon dot marchi at polymtl dot ca> <1459912543-15328-4-git-send-email-simon dot marchi at polymtl dot ca> <570BECA8 dot 3050801 at redhat dot com> <dcd2914b07d0118e12d3e0082f9f691b at simark dot ca>
On 04/11/2016 08:26 PM, Simon Marchi wrote:
> On 2016-04-11 14:27, Pedro Alves wrote:
>> On 04/06/2016 04:15 AM, Simon Marchi wrote:
>
...
>> Why did you move the check to within the loop? I thought one
>> could check [target_info exists use_gdb_stub] at the top?
>> I'd find the patch OK with that. It'd be nicer to avoid
>> gdb_start_cmd in the first place, but use_gdb_stub is still
>> an improvement.
>
> You're right, I didn't think to check [target_info exists use_gdb_stub]
> directly. The global variable use_gdb_stub is only available after
> having spawned gdb, which is why I moved it.
Maybe it's be simpler for users to wrap this in a proc, like:
proc use_gdb_stub {} {
global use_gdb_stub
if [target_info exists use_gdb_stub] {
return $use_gdb_stub
}
return 0
}
Then consistently use the proc.
Thanks,
Pedro Alves