This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make gdb.server/solib-list.exp work for remote targets
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 8 Apr 2016 23:33:10 +0100
- Subject: Re: [PATCH] Make gdb.server/solib-list.exp work for remote targets
- Authentication-results: sourceware.org; auth=none
- References: <1460153899-5185-1-git-send-email-simon dot marchi at ericsson dot com>
Looks good, though see comments below. Thanks for doing this.
On 04/08/2016 11:18 PM, Simon Marchi wrote:
> gdb/testsuite/ChangeLog:
>
> * gdb.server/solib-list.exp: Allow running with remote targets.
Pedantically, this is really a "why", not a "what". Should be something
around:
* gdb.server/solib-list.exp: Remove is_remote check.
Pass shlib= to gdb_compile. Don't link shared library with
-soname. Call gdb_remote_download instead of gdb_load_shlibs.
Run binary filename through "readlink -f" on the target.
> @@ -75,8 +74,7 @@ foreach nonstop { 0 1 } { with_test_prefix "non-stop $nonstop" {
> # Note we pass ${interp_system}, the program gdbserver spawns, as
> # argument here, instead of using gdb_load, because we don't want
> # to download the interpreter to the target (it's already there)
> - # or to the test output directory.
Did you remove this line on purpose? If so, missing period. :-)
BTW, I actually meant to extended it to:
"or to the test output directory, when local testing."
before pushing the previous patch, but forgot.
> - set res [gdbserver_spawn "${interp_system} ${binfile}"]
> + set res [gdbserver_spawn "${interp_system} ${remote_binfile}"]
> set gdbserver_protocol [lindex $res 0]
> set gdbserver_gdbport [lindex $res 1]
Thanks,
Pedro Alves