This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 04/11] [PR gdb/14441] gdb: parse: support rvalue reference type
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>, gdb-patches at sourceware dot org
- Date: Wed, 16 Mar 2016 15:23:53 -0700
- Subject: Re: [PATCH v3 04/11] [PR gdb/14441] gdb: parse: support rvalue reference type
- Authentication-results: sourceware.org; auth=none
- References: <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-5-git-send-email-artemiyv at acm dot org>
On 03/04/2016 07:19 PM, Artemiy Volkov wrote:
> diff --git a/gdb/parse.c b/gdb/parse.c
> index 06f7bcd..b67d1f0 100644
> --- a/gdb/parse.c
> +++ b/gdb/parse.c
> @@ -1481,8 +1481,8 @@ insert_type (enum type_pieces tp)
> union type_stack_elt element;
> int slot;
>
> - gdb_assert (tp == tp_pointer || tp == tp_reference
> - || tp == tp_const || tp == tp_volatile);
> + gdb_assert (tp == tp_pointer || tp == tp_reference ||
> + tp == tp_rvalue_reference || tp == tp_const || tp == tp_volatile);
The coding standard specifies that operators should not end a line. [Our
ARI script (ari/gdb_ari.sh) will flag this, too.]
>
> /* If there is anything on the stack (we know it will be a
> tp_pointer), insert the qualifier above it. Otherwise, simply
Keith