This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/3] PR remote/19496, interrupted syscall in forking-threads-plus-bkpt
- From: Pedro Alves <palves at redhat dot com>
- To: Don Breazeal <donb at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 16 Mar 2016 18:33:32 +0000
- Subject: Re: [PATCH v2 2/3] PR remote/19496, interrupted syscall in forking-threads-plus-bkpt
- Authentication-results: sourceware.org; auth=none
- References: <1458152750-25119-1-git-send-email-donb at codesourcery dot com>
On 03/16/2016 06:25 PM, Don Breazeal wrote:
--- a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
+++ b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
@@ -72,6 +72,7 @@ proc do_test { cond_bp_target detach_on_fork displaced } {
global decimal gdb_prompt
global linenum
global is_remote_target
+ global timeout
Don't need this.
set saved_gdbflags $GDBFLAGS
set GDBFLAGS [concat $GDBFLAGS " -ex \"set non-stop on\""]
@@ -115,18 +116,20 @@ proc do_test { cond_bp_target detach_on_fork displaced } {
set fork_count 0
set ok 0
- set test "inferior 1 exited"
- gdb_test_multiple "" $test {
- -re "Inferior 1 \(\[^\r\n\]+\) exited normally" {
- set ok 1
- pass $test
- }
- -re "Inferior $decimal \(\[^\r\n\]+\) exited normally" {
- incr fork_count
- if {$fork_count <= 100} {
- exp_continue
- } else {
- fail "$test (too many forks)"
+ with_timeout_factor 90 {
Eeeek. :-) This is a factor, not absolute time.
The default is 10 seconds, so a factor of 9 or 10
should suffice. I'd say make it 10, just because it is
round and matches the number of threads.
Otherwise OK.
Thanks,
Pedro Alves