This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions


On 03/14/2016 09:23 PM, Don Breazeal wrote:
On 1/28/2016 4:06 AM, Pedro Alves wrote:
On 01/28/2016 01:21 AM, Don Breazeal wrote:
The patch includes three new tests related to this.  One is just
gdb.linespec/ls-errs.exp copied and converted to use C++ instead of
C, and
to add a case using a file name containing a Windows-style logical drive
specifier.
....
gdb/testsuite/gdb.linespec/ls-errs-cp.cc    |  36 +++++
gdb/testsuite/gdb.linespec/ls-errs-cp.exp   | 240
++++++++++++++++++++++++++++
...

Can't we somehow reuse the existing test?  Say, either:

  - move the main body of ls-errs.exp a procedure, and call it twice,
    once for each language, or,

  - make gdb.linespec/ls-errs-cp.exp set some $language var and then
    source gdb.linespec/ls-errs.exp, like gdb.base/checkpoint-ns.exp.

Thanks,
Pedro Alves


Hi Pedro,
I used your first suggestion above.  Did you have any other comments
for this one, or is it good to go?

Sorry, that was really only a generic passer-by comment.  I'd
rather leave it to Doug or Keith to approve.

On the testcase part, it may help to post a "git diff -w" patch,
so we can see the real differences without all the reindentation
churn.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]