This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2] xtensa: add hardware breakpoints support
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>, "linux-xtensa at linux-xtensa dot org" <linux-xtensa at linux-xtensa dot org>
- Date: Thu, 10 Mar 2016 23:18:08 +0300
- Subject: Re: [PATCH 0/2] xtensa: add hardware breakpoints support
- Authentication-results: sourceware.org; auth=none
- References: <1457560106-5830-1-git-send-email-jcmvbkbc at gmail dot com> <56E1AC20 dot 30405 at redhat dot com>
On Thu, Mar 10, 2016 at 8:17 PM, Pedro Alves <palves@redhat.com> wrote:
> On 03/09/2016 09:48 PM, Max Filippov wrote:
>>
>> Hello,
>>
>> this series cleans up gdb/xtensa-linux-nat.c so that it builds without
>> warnings and adds support for hardware breakpoints and watchpoints.
>> The implementation closely follows what ARM does.
>> Please review.
>
>
> Unfortunately, you looked at one of the targets that still doesn't
> share the debug registers code with gdbserver. See how at least
> x86, aarch64 and mips put debug registers code in gdb/nat/.
Will do, thanks for the tip.
> I think we should require all new GNU/Linux debug registers
> support code follow such a scheme.
>
> Patch #1 is obvious, please push it in.
Hmm, this is already fixed on master, sorry for the noise.
--
Thanks.
-- Max