This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Enable tracing of pseudo-registers on ARM
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>, <palves at redhat dot com>
- Date: Thu, 25 Feb 2016 10:35:23 +0000
- Subject: Re: [PATCH v5] Enable tracing of pseudo-registers on ARM
- Authentication-results: sourceware.org; auth=none
- References: <56C7796B dot 3030504 at redhat dot com> <1456256486-26423-1-git-send-email-antoine dot tremblay at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> +/* Implementation of the ax_pseudo_register_collect gdbarch function. */
> +
> +static int
> +arm_ax_pseudo_register_collect (struct gdbarch *gdbarch,
> + struct agent_expr *ax, int reg)
> +{
> + int rawnum = arm_pseudo_register_to_register (gdbarch, reg);
> +
> + /* Error. */
> + if (rawnum < 0)
> + return 1;
> +
> + /* Get the remote/tdesc register number. */
> + rawnum = gdbarch_remote_register_number (gdbarch, rawnum);
> +
I am expecting your patch v6 which moves gdbarch_remote_register_number
to the else branch of ax_reg/ax_reg_mask, if I correctly follow the discussion.
> + ax_reg_mask (ax, rawnum);
> +
> + return 0;
> +}
--
Yao (éå)