This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 07/11] [PR gdb/14441] gdb: dwarf2read: support DW_AT_rvalue_reference type
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 19 Feb 2016 10:57:08 -0800
- Subject: Re: [PATCH v2 07/11] [PR gdb/14441] gdb: dwarf2read: support DW_AT_rvalue_reference type
- Authentication-results: sourceware.org; auth=none
- References: <1450661481-31178-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-8-git-send-email-artemiyv at acm dot org>
On 01/19/2016 10:53 AM, Artemiy Volkov wrote:
> Make gdb DWARF reader understand DW_AT_rvalue_reference type tag. Handling
> of this tag is done in the existing read_tag_reference_type() function, to
> which we add a new parameter representing the kind of reference type
> (lvalue vs rvalue).
>
> ./ChangeLog:
>
> 2016-01-19 Artemiy Volkov <artemiyv@acm.org>
>
> * gdb/dwarf2read.c (process_die): Handle the
> DW_AT_rvalue_reference_type DIE.
> (read_tag_reference_type): Likewise.
> (read_type_die_1): Likewise.
More "likewise," but otherwise, this looks okay to me.
Keith