This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 19 Feb 2016 10:54:16 -0800
- Subject: Re: [PATCH v2 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames
- Authentication-results: sourceware.org; auth=none
- References: <1450661481-31178-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-6-git-send-email-artemiyv at acm dot org>
All nits here, too.
On 01/19/2016 10:53 AM, Artemiy Volkov wrote:
> 2016-01-19 Artemiy Volkov <artemiyv@acm.org>
>
> * gdb/cp-name-parser.y: Handle the '&&' token in typename.
We normally put a production name in place of where one would normally
use a function name. In this case, "(ptr_operator)".
> @@ -827,7 +828,10 @@ typy_lookup_type (struct demangle_component *demangled,
> switch (demangled_type)
> {
> case DEMANGLE_COMPONENT_REFERENCE:
> - rtype = lookup_lvalue_reference_type (type);
> + rtype = lookup_lvalue_reference_type (type);
> + break;
> + case DEMANGLE_COMPONENT_RVALUE_REFERENCE:
> + rtype = lookup_rvalue_reference_type (type);
> break;
> case DEMANGLE_COMPONENT_POINTER:
> rtype = lookup_pointer_type (type);
Indentation?
Keith