This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: lgustavo at codesourcery dot com, arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org
- Date: Thu, 18 Feb 2016 17:06:37 +0100 (CET)
- Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- Authentication-results: sourceware.org; auth=none
Marcin KoÅ?cielnicki wrote:
> On 18/02/16 16:58, Ulrich Weigand wrote:
> > Ah, right. You should probably move the prototype to arch-utils.h
> > (and then the implementation to arch-utils.c) to go with the other
> > default_ functions.
>
> Alright, I'll do that.
> >
> > Since gdbarch.h is included everywhere, we try to avoid having it
> > include other headers as far as possible.
>
> FWIW, the header include I added only ends up in gdbarch.c, .h is
> unaffected.
Ah, I missed that, sorry. Anyway, it's probably still better to
have the routine in arch-utils.[ch] like the others ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com