This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.


Marcin KoÅ?cielnicki wrote:
> On 18/02/16 16:58, Ulrich Weigand wrote:
> > Ah, right.  You should probably move the prototype to arch-utils.h
> > (and then the implementation to arch-utils.c) to go with the other
> > default_ functions.
> 
> Alright, I'll do that.
> >
> > Since gdbarch.h is included everywhere, we try to avoid having it
> > include other headers as far as possible.
> 
> FWIW, the header include I added only ends up in gdbarch.c, .h is 
> unaffected.

Ah, I missed that, sorry.  Anyway, it's probably still better to
have the routine in arch-utils.[ch] like the others ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]