Re: [PATCH v2 3/3] btrace, frame: fix crash in get_frame_type

[Pedro Alves <palves at redhat dot com>]

On 02/11/2016 03:42 PM, Metzger, Markus T wrote:

>> If we don't know where the caller is, we can't skip the resolver in one go, so
>> best to do is probably to return 0, and let infrun's stepping logic continue
>> single-stepping.
> 
> You think we should add the check nevertheless in gdb/glibc-tdep.c?

Let's leave it be.  If may be that the use case that trips on it would
be best fixed differently.

> 
> The others I won't be able to test.  I could do the changes and rely on buildbot
> to flag issues.  If we really want to change them.

I don't think we should change the others without evidence that they'd need it.
If we do trip on problems on those, I think the fix should be elsewhere.

I'd still early in the release cycle, let's wait and see.

> 
> commit 0dc54d83f375e8901061244807e078f281fca070
> Author: Markus Metzger <markus.t.metzger@intel.com>
> Date:   Thu Feb 11 11:07:09 2016 +0100
> 
>     stack: check frame_unwind_caller_id
>     
>     Callers of frame_unwind_caller_* functions are supposed to check
>     frame_unwind_caller_id.
>     
>     Add such a check to frame_info and treat an invalid caller ID as if the caller
>     PC were not available.
>     
>     2016-02-11  Markus Metzger  <markus.t.metzger@intel.com>
>     
>     gdb/
>     	* stack.c (frame_info): Check frame_unwind_caller_id.
> 

OK.

Thanks,
Pedro Alves