This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [obv. PATCH 1/1] Fix build breakage


On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves

> How is this better than what Simon proposed?

> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
> Just noticed that with the e-mail from Sergio this early morning.

Simon's fix was quoted in Sergio's e-mail.  :-)

> I will revert what I just pushed,

You reverted one patch unrelated patch too:

commit 0635c8759326e9431604b3359185cbf96740521d
Author:     Walfred Tedeschi <walfred.tedeschi@intel.com>

    Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."

    This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.

I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").


BTW, given you first fixed the C++ build, and then broke it again with
the revert, you should have gotten another e-mail from the buildbot
about C++ build breakage.  Can you confirm whether you got one this time?

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]