This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] varobj: Cleanup dead code
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 07 Feb 2016 09:48:14 -0500
- Subject: Re: [PATCH] varobj: Cleanup dead code
- Authentication-results: sourceware.org; auth=none
- References: <1454300223-10407-1-git-send-email-simon dot marchi at polymtl dot ca> <20160207125629 dot GC20874 at adacore dot com>
On 2016-02-07 07:56, Joel Brobecker wrote:
FTR: There is actually no real agreement on this, and because each
approach has its advantages, short of a royal edict, we'll probably
continue accepting both forms.
Ah ok, I though it was agreed.
gdb/ChangeLog:
* varobj.h (varobj_delete): Remove dellist parameter, update and
move documentation here.
* varobj.c (struct cpstack, cppush, cppop): Remove.
(delete_variable): Remove resultp (first) parameter.
(delete_variable_1): Likewise.
(varobj_delete): Remove dellist parameter and unused code.
(update_dynamic_varobj_children): Adjust varobj_delete call.
(update_type_if_necessary): Likewise.
(varobj_set_visualizer): Likewise.
(varobj_update): Likewise.
(value_of_root): Likewise.
(varobj_invalidate_iter): Likewise.
* mi/mi-cmd-var.c (mi_cmd_var_delete): Likewise.
Looks good to me.
Thanks for doing that cleanup.
Pushed, thanks!