This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 0/4] Add support for "legacy" linespecs
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 7 Feb 2016 16:28:15 +0400
- Subject: Re: [PATCH V2 0/4] Add support for "legacy" linespecs
- Authentication-results: sourceware.org; auth=none
- References: <20160201220928 dot 1415 dot 59039 dot stgit at valrhona dot uglyboxes dot com>
> When I committed the locations API patchset, I ignored the need for
> "legacy" support. Specifically, MI, python, and guile all require the
> ability to convert an old-style linespec (which can be a linespec, address,
> or probe location) into an event_location.
>
> Python and guile code assumes everything is a linespec location, so neither
> probe nor address locations are available to them.
>
> MI uses string_to_event_location, but that allows CLI-style explicit
> locations. MI already supports MI-style explicit locations.
>
> This patchset is an attempt to address this by adding a new locations API
> function, string_to_event_location_basic, which implements a generic
> string-to-struct event_location routine which converts these (so-called)
> "legacy" linespecs.
FWIW, I like this patch series, and I saw no issues with it.
It is nice to see both Python and Guile + how easily GDB/MI
was adjusted.
Thanks, Keith!
--
Joel