This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V5 3/5] Add bound related fields to the siginfo structure
- From: Pedro Alves <palves at redhat dot com>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>, eliz at gnu dot org, brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 28 Jan 2016 12:23:23 +0000
- Subject: Re: [PATCH V5 3/5] Add bound related fields to the siginfo structure
- Authentication-results: sourceware.org; auth=none
- References: <1453474456-13169-1-git-send-email-walfred dot tedeschi at intel dot com> <1453474456-13169-4-git-send-email-walfred dot tedeschi at intel dot com>
On 01/22/2016 02:54 PM, Walfred Tedeschi wrote:
> Both Linux and glibc have introduced bound related fields in the segmentation fault fields of the
> siginfo_t type. Ass the new fields to our x86's siginfo_t type too.
"Add the " ...
> @@ -342,6 +344,18 @@ linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch,
> /* _sigfault */
> type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> append_composite_type_field (type, "si_addr", void_ptr_type);
> +
> + /* additional bound fields for _sigfault in case they are added. */
"Additional", uppercase.
"in case they were requested.".
> + if ((extra_fields & LINUX_SIGINFO_FIELD_ADDR_BND) != 0)
> + {
OK with those changes.
Thanks,
Pedro Alves