This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] PR 18303, Tolerate malformed input for lookup_symbol-called functions.
- From: Pedro Alves <palves at redhat dot com>
- To: Don Breazeal <donb at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 28 Jan 2016 12:06:34 +0000
- Subject: Re: [PATCH v2] PR 18303, Tolerate malformed input for lookup_symbol-called functions.
- Authentication-results: sourceware.org; auth=none
- References: <1453944094-31885-1-git-send-email-donb at codesourcery dot com>
On 01/28/2016 01:21 AM, Don Breazeal wrote:
> The patch includes three new tests related to this. One is just
> gdb.linespec/ls-errs.exp copied and converted to use C++ instead of C, and
> to add a case using a file name containing a Windows-style logical drive
> specifier.
....
> gdb/testsuite/gdb.linespec/ls-errs-cp.cc | 36 +++++
> gdb/testsuite/gdb.linespec/ls-errs-cp.exp | 240 ++++++++++++++++++++++++++++
...
Can't we somehow reuse the existing test? Say, either:
- move the main body of ls-errs.exp a procedure, and call it twice,
once for each language, or,
- make gdb.linespec/ls-errs-cp.exp set some $language var and then
source gdb.linespec/ls-errs.exp, like gdb.base/checkpoint-ns.exp.
Thanks,
Pedro Alves