This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines.
- From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- To: gdb-patches at sourceware dot org
- Cc: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- Date: Fri, 22 Jan 2016 14:56:55 +0100
- Subject: [PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines.
- Authentication-results: sourceware.org; auth=none
Noticed and tested on s390. This bug caused completely broken fast
tracepoints. No regressions on i686, x86_64, s390x.
gdb/gdbserver/ChangeLog:
* tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
it works properly on big-endian machines where sizeof (CORE_ADDR)
!= sizeof (void *).
---
Another patch for upcoming s390 tracepoint support. 31-bit fast tracepoints
are still broken, but now less so.
It seems tracepoints are still broken in multiple ways on big-endian
targets, and I'm going to fix that. However, I'm not sure what to do
about the bi-arch case mentioned in the comment. While it'd be nice
to handle libinproctrace.so like libgcc.so and build it for all multilib
configurations, atm C structures involving pointers are shared between
gdbserver and the IPA. This obviously would have to be refactored before
that's possible, but might be worth it - configuring a full 31-bit build
just to get fast tracepoints is a pain.
gdb/gdbserver/ChangeLog | 6 ++++++
gdb/gdbserver/tracepoint.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 9c42fcf..6ddd9ce 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2016-01-22 Marcin KoÅcielnicki <koriakin@0x04.net>
+
+ * tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
+ it works properly on big-endian machines where sizeof (CORE_ADDR)
+ != sizeof (void *).
+
2016-01-21 Pedro Alves <palves@redhat.com>
* Makefile.in (COMPILER_CFLAGS, CXXFLAGS): New.
diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index 40d0da9..536cdd5 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -5931,14 +5931,14 @@ compile_tracepoint_condition (struct tracepoint *tpoint,
*jump_entry += 16;
}
-/* We'll need to adjust these when we consider bi-arch setups, and big
- endian machines. */
+/* We'll need to adjust these when we consider bi-arch setups. */
static int
write_inferior_data_ptr (CORE_ADDR where, CORE_ADDR ptr)
{
+ uintptr_t pptr = ptr;
return write_inferior_memory (where,
- (unsigned char *) &ptr, sizeof (void *));
+ (unsigned char *) &pptr, sizeof pptr);
}
/* The base pointer of the IPA's heap. This is the only memory the
--
2.7.0