This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 20 Jan 2016 13:45:29 -0500
Subject: Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter
Authentication-results: sourceware.org; auth=none
References: <1453313447-21194-1-git-send-email-simon dot marchi at polymtl dot ca> <569FCFE6 dot 8020002 at redhat dot com>

On 2016-01-20 13:20, Pedro Alves wrote:

On 01/20/2016 06:10 PM, Simon Marchi wrote:

  I noticed that I could change the regexps to almost anything and the
tests would still pass. I think it was because of the | in there.I
  made them more robust by using string_to_regexp.


You can use gdb_test_exact instead, which does the string_to_regexp
for you.  OK with that change.


Ok, pushed with that change.

Thanks.

References:
- [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter
  - From: Simon Marchi
- Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]