This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Remove references to HP CC/aCC compiler from testsuite
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 20 Dec 2015 10:39:46 -0500
- Subject: Re: [PATCH 2/3] Remove references to HP CC/aCC compiler from testsuite
- Authentication-results: sourceware.org; auth=none
- References: <CAFXXi0=w-kO_a0dgaLhdzESKU9jZc3BDNiWknGEW3QA3GZkdTA at mail dot gmail dot com> <20151220051518 dot GC4639 at adacore dot com>
On 20 December 2015 at 00:15, Joel Brobecker <brobecker@adacore.com> wrote:
>> From 8d7c3cff8ced75bedbe050d3fefde10e3349de70 Mon Sep 17 00:00:00 2001
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Date: Sat, 19 Dec 2015 11:36:49 -0500
>> Subject: [PATCH] Remove references to HP CC/aCC compiler from testsuite
>>
>> The HP CC/aCC compiler is exclusive to HP-UX, for which support has been
>> explicitely removed. Therefore, It does not make sense to keep tests
>
> "explicitly"
Fixed.
>> for these compilers' quirks.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.base/break.exp: Remove references to HP CC/aCC compilers.
>> * gdb.base/call-ar-st.exp: Likewise.
>> * gdb.base/callfuncs.exp: Likewise.
>> * gdb.base/condbreak.exp: Likewise.
>> * gdb.base/constvars.exp: Likewise.
>> * gdb.base/hbreak2.exp: Likewise.
>> * gdb.base/langs.exp: Likewise.
>> * gdb.base/list.exp: Likewise.
>> * gdb.base/long_long.exp: Likewise.
>> * gdb.base/ptype.exp: Likewise.
>> * gdb.base/scope.exp: Likewise.
>> * gdb.base/signals.exp: Likewise.
>> * gdb.base/so-impl-ld.exp: Likewise.
>> * gdb.base/varargs.exp: Likewise.
>> * gdb.base/volatile.exp: Likewise.
>> * gdb.base/whatis.exp: Likewise.
>> * gdb.cp/cplusfuncs.exp: Likewise.
>> * gdb.cp/inherit.exp: Likewise.
>> * gdb.cp/local.exp: Likewise.
>> * gdb.cp/member-ptr.exp: Likewise.
>> * gdb.cp/method.exp: Likewise.
>> * gdb.cp/overload.exp: Likewise.
>> * gdb.cp/templates.exp: Likewise.
>> * gdb.stabs/weird.exp: Likewise.
>> * lib/compiler.c: Likewise.
>> * lib/compiler.cc: Likewise.
>> * lib/cp-support.exp: Likewise.
>> * lib/gdb.exp: Likewise.
>
> OK for me.
>
> Note that there was one area where an expected output alternative
> was removed which mentioned hp aCC, but also GCC 2.95. I assumed
> it's OK to only support more recent versions than 2.95 ;-).
Indeed, I didn't feel too bad removing it.
I'll push this patch at the same time as 3/3, so it'll give some time
to other people who want to take a look at it.
Thanks for the review!