This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix -Wno-unknown-warning support detection
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Wed, 16 Dec 2015 23:13:35 +0000
- Subject: Re: [PATCH] Fix -Wno-unknown-warning support detection
- Authentication-results: sourceware.org; auth=none
- References: <1450306675-8885-1-git-send-email-palves at redhat dot com> <5671EECA dot 4080206 at ericsson dot com>
On 12/16/2015 11:07 PM, Simon Marchi wrote:
> It looks good.
I pushed it, thanks.
Note that you could have done
>
> wtest=`echo $w | sed 's/-Wno-/-W/g'`
>
> unconditionally. If it doesn't match, it won't replace anything:
>
> $ echo -Wlol | sed 's/-Wno-/-W/g'
> -Wlol
> $ echo -Wno-lol | sed 's/-Wno-/-W/g'
> -Wlol
Yep, but I wrote it like that to avoid spawning external
processes unless necessary. That adds up and slows configure down.
Thanks,
Pedro Alves