This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 4/9] Explicit locations: introduce address locations
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Dec 2015 17:39:48 +0400
- Subject: Re: [PATCH v6 4/9] Explicit locations: introduce address locations
- Authentication-results: sourceware.org; auth=none
- References: <20150805232802 dot 21646 dot 88440 dot stgit at valrhona dot uglyboxes dot com> <20150805232951 dot 21646 dot 67733 dot stgit at valrhona dot uglyboxes dot com> <20151214071113 dot GA6230 at adacore dot com> <566F2CF1 dot 1030003 at redhat dot com>
> I guess when it boils down to it, I don't really have a super strong
> preference for either case, but I do have a preference for maintaining
> addresses as a separate location type. What can I say? I hate special
> cases! :-P
>
> > WDYT? I admit I'm a little lost still between the various layers
> > of locations, event_locations, etc. Do you want to take it from there?
>
> I am more than happy to fix anything related to this code in any
> appropriate manner dictated by maintainers. [Of course, if this involves
> a massive rewrite, I will have to clear with my management!]
>
> Let me know how you and other maintainers would like me to proceed.
Thanks for your insights, Keith. I agree the choice is not clearly
black or white; but because you probably know this area better than
anyone, I'm inclined to follow your suggestion. Given that the patch
I sent is close to what you would have written, I think it makes sense
for me to see this through, and have you help with the review? Any
comments on the current one before I proceed with a more official
submission?
Thanks!
--
Joel