This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: AArch64 sim: Add support for the MRS instruction
- From: Nick Clifton <nickc at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 15 Dec 2015 11:04:21 +0000
- Subject: Re: RFA: AArch64 sim: Add support for the MRS instruction
- Authentication-results: sourceware.org; auth=none
- References: <87oadtougj dot fsf at redhat dot com> <20151214205535 dot GZ11489 at vapier dot lan>
Hi Mike,
PS. I would be happy to be a maintainer for the AArch64 sim, if that is
agreeable.
sounds fine
Great - in which case is it OK to check in the attached patch ?
+static uint64_t
+system_get (sim_cpu * cpu, unsigned op0, unsigned op1, unsigned crn,
no space after the "*"
Oops.
+static void
+do_mrs (sim_cpu * cpu)
same here
Doh.
+ /*
if (uimm (aarch64_get_instr (cpu), 21, 20) == 0x1)
- /* MSR <sys-reg>, <Xreg>. */
- return;
+ do_msr (cpu); */
HALT_NYI;
+ return;
should there be a TODO or some other note explaining why the code
is commented out ?
Yes - the comment was intended to indicate that this is where the
implementation of the MSR instruction should begin, but only if bit 21
is clear and bit 20 is set.
I have checked in a revised version of the patch with the changes you
suggested.
Cheers
Nick
diff --git a/sim/MAINTAINERS b/sim/MAINTAINERS
index 8dbb457..3cdabf4 100644
--- a/sim/MAINTAINERS
+++ b/sim/MAINTAINERS
@@ -13,6 +13,7 @@ Mike Frysinger vapier@gentoo.org
Maintainers for particular sims:
+aarch64 Nick Clifton <nickc@redhat.com>
arm Nick Clifton <nickc@redhat.com>
bfin Mike Frysinger <vapier@gentoo.org>
cr16 M R Swami Reddy <MR.Swami.Reddy@nsc.com>