This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 02 Dec 2015 11:32:05 +0000
- Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- Authentication-results: sourceware.org; auth=none
- References: <564F998D dot 5080406 at gmail dot com>
Ruslan Kabatsayev <b7.10110111@gmail.com> writes:
Hi Ruslan,
> When `info float` is used on an AMD64 system, GDB prints floating-point
> values of x87 registers with raw contents like 0x361a867a8e0527397ce0 or
> 0xc4f988454a1ddd3cfdab wrongly. This happens due to truncation to double,
> after which the former becomes 0.0, and the latter becomes negative infinity.
> This is caused by failed detection of x86-64 host, which results in setting
> gdb_host_{float,double,long_double}_format to zeros.
> This commit fixes this misdetection.
I think your patch is correct, but I am not confident approving it
because I know few about floating point stuff. Do you run GDB
regression tests?
>
> gdb/ChangeLog:
>
> * configure.host: Fix detection of x86_64 host when setting floatformats
This line is too long, the max is 74. Sentence should be ended with ".".
--
Yao (éå)