This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/3] Display names of remote threads
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 27 Nov 2015 14:37:14 +0000
- Subject: Re: [PATCH v2 2/3] Display names of remote threads
- Authentication-results: sourceware.org; auth=none
- References: <1448488138-2360-1-git-send-email-simon dot marchi at ericsson dot com> <1448488138-2360-3-git-send-email-simon dot marchi at ericsson dot com> <5656EDB8 dot 8030803 at redhat dot com> <56572AA0 dot 9070904 at ericsson dot com>
Simon Marchi <simon.marchi@ericsson.com> writes:
> + attr = xml_find_attribute (attributes, "name");
> + item.name = attr != NULL ? xstrdup (attr->value) : NULL;
> +
This breaks the C++ build,
/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c: In function âvoid start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, VEC_gdb_xml_value_s*)â:
/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:2975:50: error: invalid conversion from âvoid*â to âconst char*â [-fpermissive]
item.name = attr != NULL ? xstrdup (attr->value) : NULL;
^
In file included from /home/yao/SourceCode/gnu/gdb/git/gdb/common/common-defs.h:64:0,
from /home/yao/SourceCode/gnu/gdb/git/gdb/defs.h:28,
from /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:22:
/home/yao/SourceCode/gnu/gdb/git/gdb/../include/libiberty.h:323:14: note: initializing argument 1 of âchar* xstrdup(const char*)â
extern char *xstrdup (const char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL;
and I think you've already received the mail from buildbot.
http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1413
--
Yao (éå)