This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 03/18] attach + target always in non-stop mode: stop all threads
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 26 Nov 2015 16:12:39 +0000
- Subject: Re: [PATCH 03/18] attach + target always in non-stop mode: stop all threads
- Authentication-results: sourceware.org; auth=none
- References: <1444836486-25679-1-git-send-email-palves at redhat dot com> <1444836486-25679-4-git-send-email-palves at redhat dot com> <86r3ki0vzy dot fsf at gmail dot com> <565357B1 dot 4070805 at redhat dot com>
Pedro Alves <email@example.com> writes:
> It actually ends up being the same, and bit more generic to go with
> lowest, because target_attach should always adds the main thread first.
> Otherwise, there's no such concept of "main" thread in the common code.
> "The thread with pid == lwpid" holds true for NTPL/Linux, but not everywhere,
> and even then the leader thread may have exited already. I'll update
> the comment.
Yes, there is no such concept of "main" thread. My real concern on
"choosing lowest one" is about pid recycling. Our intention is to pick up
main thread, but the lowest one may not be the main thread if pid
recycling is considered.