This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 10/10] Enable conditional breakpoints for targets that support software single step in GDBServer.
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 26 Nov 2015 10:34:53 -0500
- Subject: Re: [PATCH v3 10/10] Enable conditional breakpoints for targets that support software single step in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1448287968-12907-1-git-send-email-antoine dot tremblay at ericsson dot com> <1448287968-12907-11-git-send-email-antoine dot tremblay at ericsson dot com> <86d1uxxdkg dot fsf at gmail dot com>
On 11/26/2015 05:25 AM, Yao Qi wrote:
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }
There should be more PASS in the test result, what are they?
(gdb) PASS: gdb.base/cond-eval-mode.exp: set breakpoint
condition-evaluation target
(gdb) PASS: gdb.base/cond-eval-mode.exp: probe for target remote
(gdb) PASS: gdb.base/cond-eval-mode.exp: set remote
conditional-breakpoints-packet off
(gdb) PASS: gdb.base/cond-eval-mode.exp: set breakpoint
condition-evaluation target, with support disabled
(gdb) PASS: gdb.base/cond-eval-mode.exp: set remote
conditional-breakpoints-packet on
(gdb) PASS: gdb.base/cond-eval-mode.exp: restore set breakpoint
condition-evaluation target
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: break foo
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: condition $bpnum
cond_global==0
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: break foo
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: condition $bpnum
cond_global==1
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: b bar
(gdb) PASS: gdb.base/cond-eval-mode.exp: break: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: hbreak foo
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: condition $bpnum
cond_global==0
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: hbreak foo
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: condition $bpnum
cond_global==1
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: b bar
(gdb) PASS: gdb.base/cond-eval-mode.exp: hbreak: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: watch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: condition $bpnum
cond_global==0
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: watch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: condition $bpnum
cond_global==1
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: b bar
(gdb) PASS: gdb.base/cond-eval-mode.exp: watch: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: rwatch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: condition $bpnum
cond_global==0
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: rwatch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: condition $bpnum
cond_global==1
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: b bar
(gdb) PASS: gdb.base/cond-eval-mode.exp: rwatch: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: awatch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: condition $bpnum
cond_global==0
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: continue
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: awatch global
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: condition $bpnum
cond_global==1
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: b bar
(gdb) PASS: gdb.base/cond-eval-mode.exp: awatch: continue
Should these be part of the commit log ?
as :
New tests passing :
PASS: gdb.base/cond-eval-mode.exp: set breakpoint condition-evaluation
target and related...
Maybe?
Thanks,
Antoine Tremblay