This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] building on musl: #include sys/types.h for mode_t
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 22 Nov 2015 17:28:10 -0800
- Subject: Re: [PATCH] building on musl: #include sys/types.h for mode_t
- Authentication-results: sourceware.org; auth=none
- References: <86ziz27urp dot fsf at sspiff dot org> <56310C96 dot 5050709 at redhat dot com> <563112BD dot 60505 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> On 10/28/2015 05:57 PM, Pedro Alves wrote:
>> On 10/28/2015 05:44 PM, Doug Evans wrote:
>>> Hi.
>>
>> Hi there,
>>
>>>
>>> Turns out there was a fourth patch. :-)
>>
>> :-)
>>
>>>
>>> 2015-10-28 Doug Evans <xdje42@gmail.com>
>>>
>>> * target.h: #include <sys/types.h>
>>>
>>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>>> index a14c6ff..f3fcd6c 100644
>>> --- a/gdb/gdbserver/target.h
>>> +++ b/gdb/gdbserver/target.h
>>> @@ -21,6 +21,7 @@
>>> #ifndef TARGET_H
>>> #define TARGET_H
>>>
>>> +#include <sys/types.h> /* for mode_t */
>>
>> Where is mode_t referenced? (what's the error?)
>
> Nevermind, I didn't notice I was was grepping an old tree,
> which predates target->multifs_open.
>
> Patch LGTM.
>
> Thanks,
> Pedro Alves
Committed, thanks.