This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 6/6] [C++] Default to -Werror in C++ mode too
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 18 Nov 2015 16:40:02 +0000
- Subject: [PATCH 6/6] [C++] Default to -Werror in C++ mode too
- Authentication-results: sourceware.org; auth=none
- References: <1447864802-24016-1-git-send-email-palves at redhat dot com>
Both x86_64 GNU/Linux and x86_64 mingw-w64 build cleanly with
--enable-targets=all. This enables -Werror by default in C++ mode
too, in order to let the buildbot catch C++ build regressions for us.
gdb/ChangeLog:
2015-11-18 Pedro Alves <palves@redhat.com>
* configure.ac (ERROR_ON_WARNING): Don't check whether in C++
mode.
* configure: Regenerate.
gdb/gdbserver/ChangeLog:
2015-11-18 Pedro Alves <palves@redhat.com>
* configure.ac (ERROR_ON_WARNING): Don't check whether in C++
mode.
* configure: Regenerate.
---
gdb/configure | 7 ++-----
gdb/configure.ac | 7 ++-----
gdb/gdbserver/configure | 3 +--
gdb/gdbserver/configure.ac | 3 +--
4 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index 8ef3cf2..249a399 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -14293,11 +14293,8 @@ if test "${enable_werror+set}" = set; then :
fi
-# Enable -Werror by default when using gcc in C mode. Leave it off
-# for C++ until we're warning clean. Turn it off for releases.
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \
- && test x"$enable_build_with_cxx" != x"yes" \
- && $development; then
+# Enable -Werror by default when using gcc. Turn it off for releases.
+if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then
ERROR_ON_WARNING=yes
fi
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 29d0b63..ebd797b 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1932,11 +1932,8 @@ AC_ARG_ENABLE(werror,
*) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
esac])
-# Enable -Werror by default when using gcc in C mode. Leave it off
-# for C++ until we're warning clean. Turn it off for releases.
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \
- && test x"$enable_build_with_cxx" != x"yes" \
- && $development; then
+# Enable -Werror by default when using gcc. Turn it off for releases.
+if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then
ERROR_ON_WARNING=yes
fi
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 4b9aa95..87dfda0 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6106,8 +6106,7 @@ if test "${enable_werror+set}" = set; then :
fi
-# Enable -Werror by default when using gcc in C mode. Leave it off
-# for C++ until we're warning clean. Turn it off for releases.
+# Enable -Werror by default when using gcc. Turn it off for releases.
if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \
&& test x"$enable_build_with_cxx" != x"yes" \
&& $development; then
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 0fe0a35..d50d0f1 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -157,8 +157,7 @@ AC_ARG_ENABLE(werror,
*) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
esac])
-# Enable -Werror by default when using gcc in C mode. Leave it off
-# for C++ until we're warning clean. Turn it off for releases.
+# Enable -Werror by default when using gcc. Turn it off for releases.
if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" \
&& test x"$enable_build_with_cxx" != x"yes" \
&& $development; then
--
1.9.3