This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 2/2] Fix gdb.threads/multiple-step-overs.exp fails on arm
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 17 Nov 2015 15:41:17 +0000
- Subject: Re: [PATCH 2/2] Fix gdb.threads/multiple-step-overs.exp fails on arm
- Authentication-results: sourceware.org; auth=none
- References: <1446130862-12824-1-git-send-email-yao dot qi at linaro dot org> <1446130862-12824-3-git-send-email-yao dot qi at linaro dot org> <563A3E3F dot 9060204 at redhat dot com> <86d1vjxvp5 dot fsf at gmail dot com> <564B1E89 dot 1000604 at redhat dot com>
Pedro Alves <email@example.com> writes:
> The reason we resume a single thread and leave others stopped when doing a
> normal step over where we temporarily remove the breakpoint, single-step,
> reinsert the breakpoint, is that if we let other threads run in the period
> while the breakpoint is removed, then these other threads could miss
> the breakpoint. Since with displaced stepping, we don't ever remove the
> breakpoint, it should be fine to let other threads run. However,
> there's another
> reason that we should not let other threads run: that is the case where some of
> those threads are also stopped for a breakpoint that itself needs to be
> stepped over. If we just let those threads run, then they immediately re-trap
> their breakpoint again.
OK, copy them into the commit log.
>> Patch below is regression tested on x86_64-linux and arm-linux.
Patch is pushed in.