This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: [ARM] "svc" insn check at irrelevant address in ARM unwind info sniffer
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Mon, 16 Nov 2015 10:16:22 +0000
- Subject: Re: RFA: [ARM] "svc" insn check at irrelevant address in ARM unwind info sniffer
- Authentication-results: sourceware.org; auth=none
- References: <1447092513-20690-1-git-send-email-brobecker at adacore dot com> <86y4e5wxy9 dot fsf at gmail dot com> <20151115172537 dot GA10374 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> writes:
Hi Joel,
> I will start by saying that I see you point. If we're in a frame whose
> first instruction is a call, then we could be seeing the same issue.
> I would also argue that innermost-ness is important, here, assuming
> that we agree that the ARM info is only correct at the point of call.
> So, strictly speaking, we should not even be attempting to use it
> for innermost frame.
Yes, that is true.
>
> Should I work on a version of the patch that merges the two ideas?
> Or do you stand with just checking "get_frame_pc (this_frame) >
> func_start"? I confess I know ARM unwind info just enough to get by,
> so I trust your judgement on this.
Let us start from the simple thing, just checking
"get_frame_pc (this_frame) > func_start". If we need to check
innermost-ness for other problems in the future, we can add it then.
--
Yao (éå)