This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 0/3] Support for x86 segments as address classes
- From: Pedro Alves <palves at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>, gdb-patches at gcc dot gnu dot org
- Date: Thu, 05 Nov 2015 11:21:07 +0000
- Subject: Re: [PATCH 0/3] Support for x86 segments as address classes
- Authentication-results: sourceware.org; auth=none
- References: <1446558190-13482-1-git-send-email-rth at redhat dot com>
On 11/03/2015 01:43 PM, Richard Henderson wrote:
> The following gets 90% of the way there, but I'm stuck --
> address_to_pointer and pointer_to_address do not appear to
> have access to a regcache. And not just in the one level
> of the caller, but significantly farther back in the call
> stack too.
The first two patches look generally good to me. Though
you'll need to update the manual and NEWS as well to document
the new target feature. (Also, I know this is a WIP, but
note that in gdb we strive to have the rationale for changes
in the git commit logs.)
> Which begs the question of whether I've simply missed
> something in how to get hold of the current regcache?
get_current_frame / get_current_regcache ? If you can pass it down
through a couple layers, it's of course better.
Though I'm not sufficiently familiar with the address class
mechanisms be to sure I'm not pointing you in the
wrong direction. Ulrich, can you help?