This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.


On 03/11/15 17:13, Ulrich Weigand wrote:
Marcin KoÃ…cielnicki <koriakin at 0x04 dot net> wrote:

gdb/ChangeLog:

	PR/18376
	* gdb/s390-linux-tdep.c (s390_is_partial_instruction): New function.
	(s390_software_single_step): New function.
	(s390_displaced_step_hw_singlestep): New function.
	(s390_gdbarch_init): Fill gdbarch slots with the above.

+  /* Special handling only if recording.  */
+  if (!record_full_is_used())
+    return 0;
+
+  /* First, match a partial instruction.  */
+  if (!s390_is_partial_instruction(gdbarch, loc, &len))
+    return 0;

Coding style issue: space before ( for function calls.

Patch is OK with that change.

Thanks,
Ulrich


Thanks for the review. Should I push these two patches already, or wait for review on the xmalloc one first? [https://sourceware.org/ml/gdb-patches/2015-11/msg00021.html]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]