This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: gdb-patches at sourceware dot org, koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Date: Tue, 3 Nov 2015 17:13:21 +0100 (CET)
- Subject: Re: [PATCH v3 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit.
- Authentication-results: sourceware.org; auth=none
Marcin KoÃ?cielnicki <koriakin at 0x04 dot net> wrote:
> gdb/ChangeLog:
>
> PR/18376
> * gdb/s390-linux-tdep.c (s390_is_partial_instruction): New function.
> (s390_software_single_step): New function.
> (s390_displaced_step_hw_singlestep): New function.
> (s390_gdbarch_init): Fill gdbarch slots with the above.
> + /* Special handling only if recording. */
> + if (!record_full_is_used())
> + return 0;
> +
> + /* First, match a partial instruction. */
> + if (!s390_is_partial_instruction(gdbarch, loc, &len))
> + return 0;
Coding style issue: space before ( for function calls.
Patch is OK with that change.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com